Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yt upload support #1

Open
wants to merge 10 commits into
base: remove-yt-password-storage
Choose a base branch
from

Conversation

Vekhir
Copy link
Owner

@Vekhir Vekhir commented Feb 12, 2025

To be merged after or in conjunction with OpenBoard-org#1023.

YouTube upload hasn't worked in several years. The number of users is therefore likely 0. Since it's just bitrotting and nobody wants to maintain it, it should be removed.

The removal is done incrementally, first removing the upload utility from the UI, later removing the now unused functions and files. This allows to simplify the settings and the podcast utility.

The password is saved in an insecure way and is only used for
later auto-fill-in. Password managers are a better fit for that.
The proxy credentials are currently stored in an insecure way, and
should not be stored persistently if it can be avoided.

For architectural reasons, the credentials have to be saved for the
runtime of the program to be accessed by the network manager.

Clear the credentials at the end of the program.
These methods are no longer used due to insecure practices, thus
remove them.
They are no longer used anywhere.
No UBCryptoUtils object will ever created, so destroy() is a noop.
Remove unused public functions
They provide no public functions and as such can be safely removed.
Also remove them from the build system (qmake and cmake).
@Vekhir Vekhir force-pushed the remove-yt-password-storage branch from 8e9501b to a448788 Compare February 12, 2025 15:15
@Vekhir Vekhir force-pushed the remove-yt-upload-support branch from 7053dcb to 15748c8 Compare February 12, 2025 15:19
It hasn't worked for a few years due to API changes made by YT.
The dialog is inaccessible and uploading doesn't work due to outdated API

Youtube upload support gets removed, including this dialog
Publishing to YouTube was non-functional due to API changes on their part.
Since noone reported issues with it, it is reasonable to assume that there
are no users. Since the functionality is unmaintained, remove it entirely.

In previous commits, the upload function was made inaccessible. Now remove
the actual files.
The `youTubePublishingDialog.ui` form is unused since the
corresponding dialog code got removed.

Related settings like storing the username are removed.

Translations have to be cleaned up at a later point.
@Vekhir Vekhir force-pushed the remove-yt-upload-support branch from 15748c8 to 3f8871c Compare February 12, 2025 15:21
@Vekhir Vekhir force-pushed the remove-yt-password-storage branch from a448788 to fe6c157 Compare February 19, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant