forked from OpenBoard-org/OpenBoard
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove yt upload support #1
Open
Vekhir
wants to merge
10
commits into
remove-yt-password-storage
Choose a base branch
from
remove-yt-upload-support
base: remove-yt-password-storage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The password is saved in an insecure way and is only used for later auto-fill-in. Password managers are a better fit for that.
The proxy credentials are currently stored in an insecure way, and should not be stored persistently if it can be avoided. For architectural reasons, the credentials have to be saved for the runtime of the program to be accessed by the network manager. Clear the credentials at the end of the program.
These methods are no longer used due to insecure practices, thus remove them.
They are no longer used anywhere.
No UBCryptoUtils object will ever created, so destroy() is a noop. Remove unused public functions
They provide no public functions and as such can be safely removed. Also remove them from the build system (qmake and cmake).
8e9501b
to
a448788
Compare
7053dcb
to
15748c8
Compare
It hasn't worked for a few years due to API changes made by YT.
The dialog is inaccessible and uploading doesn't work due to outdated API Youtube upload support gets removed, including this dialog
Publishing to YouTube was non-functional due to API changes on their part. Since noone reported issues with it, it is reasonable to assume that there are no users. Since the functionality is unmaintained, remove it entirely. In previous commits, the upload function was made inaccessible. Now remove the actual files.
The `youTubePublishingDialog.ui` form is unused since the corresponding dialog code got removed. Related settings like storing the username are removed. Translations have to be cleaned up at a later point.
15748c8
to
3f8871c
Compare
a448788
to
fe6c157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after or in conjunction with OpenBoard-org#1023.
YouTube upload hasn't worked in several years. The number of users is therefore likely 0. Since it's just bitrotting and nobody wants to maintain it, it should be removed.
The removal is done incrementally, first removing the upload utility from the UI, later removing the now unused functions and files. This allows to simplify the settings and the podcast utility.